[SHOW PR] Submodulev2 #44
Open
Commits on Mar 29, 2023
-
[EXAMPLE DIFF] (Tree featuresv2) Fork of sklearn that maintains all n…
…ecessary refactorings to enable downstream functionality (#32) #### Reference Issues/PRs This is the most up-to-date PR branch to consolidate all proposed refactor changes that work with: - unsupervised trees - oblique trees - no performance/runtime regressions against main #### What does this implement/fix? Explain your changes. Incorporates refactors to: Internal Cython of scikit-learn's: - criterion - splitter - tree Internals of Python in scikit-learns: - python Tree Adds the basic implementation of oblique trees. The implementation of oblique trees has been tested on all sklearn's `check_estimator` testing function and has error-checking bounds for the new hyperparameter introduced, which is `feature_combinations` that defaults to ``min(1.5, n_features)``. TODO: 1. [ ] ~Add honest support for trees (splitting the data at the Python API level)~ 2. [x] Build wheels 3. [ ] ~Brainstorm unit-tests, or weekly checks to determine when our fork is out-of-date compared to upstream sklearn~ 4. [x] Revamp README for the fork #### Any other comments? [cd build] --------- Signed-off-by: Adam Li <adam2392@gmail.com> Co-authored-by: Chester Huynh <chester.huynh924@gmail.com> Co-authored-by: Parth Vora <pvora4@jhu.edu>
3 people committedMar 29, 2023 -
-
#### Reference Issues/PRs Fixes README and wheel building --------- Signed-off-by: Adam Li <adam2392@gmail.com>
-
Commits on Mar 30, 2023
Commits on Apr 4, 2023
-
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/main/CONTRIBUTING.md --> #### Reference Issues/PRs <!-- Example: Fixes scikit-learn#1234. See also scikit-learn#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> #### What does this implement/fix? Explain your changes. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! --> --------- Signed-off-by: Adam Li <adam2392@gmail.com>
-
Commits on Apr 6, 2023
Commits on Apr 12, 2023
Commits on Apr 13, 2023
Commits on Apr 17, 2023
Commits on Apr 19, 2023
Commits on Apr 20, 2023
Commits on Jun 8, 2023
-
-
Successful merge with the missing value support
Signed-off-by: Adam Li <adam2392@gmail.com>
-
Signed-off-by: Adam Li <adam2392@gmail.com>
Commits on Jun 12, 2023
Commits on Jun 13, 2023
-
-
Signed-off-by: Adam Li <adam2392@gmail.com>
-
Signed-off-by: Adam Li <adam2392@gmail.com>
Commits on Jun 15, 2023
-
[ENH] Adding leaf node samples to be stored when "quantile" tree is t…
…urned on (#45) #### Reference Issues/PRs Addresses the quantile-trees part of: neurodata/scikit-tree#29 #### What does this implement/fix? Explain your changes. 1. Stores for each leaf node a 2D numpy array of the y-samples (remember `y` is (n_samples, n_outputs)) 2. Does this all the way in Criterion 3. Only supports supervised tree/splitter/criterion 4. merges in `main` changes. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! --> --------- Signed-off-by: Adam Li <adam2392@gmail.com>
-
Commits on Jun 16, 2023
-
Merge branch 'submodulev2' of https://github.com/neurodata/scikit-learn…
… into submodulev2
Commits on Jun 17, 2023
Commits on Jun 20, 2023
-
Fix the predict quantiles docstring
Signed-off-by: Adam Li <adam2392@gmail.com>
-
Fix the predict quantiles docstring
Signed-off-by: Adam Li <adam2392@gmail.com>
Commits on Jun 23, 2023
-
Merging main, but with two test failures
Signed-off-by: Adam Li <adam2392@gmail.com>
Commits on Jun 27, 2023
Commits on Jun 30, 2023
-
-
Added doc to store_leaf_values
Signed-off-by: Adam Li <adam2392@gmail.com>
-
Merge branch 'submodulev2' of https://github.com/neurodata/scikit-learn…
… into submodulev2
Commits on Jul 5, 2023
-
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/main/CONTRIBUTING.md --> #### Reference Issues/PRs <!-- Example: Fixes scikit-learn#1234. See also scikit-learn#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> #### What does this implement/fix? Explain your changes. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! --> Signed-off-by: Adam Li <adam2392@gmail.com>
Commits on Jul 19, 2023
Commits on Jul 20, 2023
Commits on Aug 11, 2023
-
[MERGE] Merge changes from sklearn main (#52)
Merging latest changes from sklearn main #### What does this implement/fix? Explain your changes. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! --> --------- Signed-off-by: Adam Li <adam2392@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.