Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of SPORF #454

Open
wants to merge 31 commits into
base: sporf
Choose a base branch
from
Open

Draft of SPORF #454

wants to merge 31 commits into from

Conversation

parthgvora
Copy link
Contributor

Reference issue

Type of change

Draft of SPORF. Contains cythonization, parameters equivalent to RerF, and various bug fixes from previous python-only iteration. Still needs work!

What does this implement/fix?

Additional information

PSSF23
PSSF23 previously approved these changes Mar 21, 2021
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest linking to some DoD and show what your codes improved. But as this is a development branch, merging would not require the full procedure.

@PSSF23 PSSF23 added the draft In progress PR label Mar 21, 2021
from .morf_tree import Conv2DObliqueTreeClassifier


class Conv2DObliqueForestClassifier(ForestClassifier):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short and sweet.

@PSSF23 PSSF23 deleted the branch neurodata:sporf November 4, 2021 15:29
@PSSF23 PSSF23 closed this Nov 4, 2021
@PSSF23 PSSF23 reopened this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft In progress PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants