Update spawn-in-circle implementation in getting started doc

networked-aframe · Dec 17, 2023 · 8ba5969 · 8ba5969
1 parent abbf091
commit 8ba5969
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/docs/getting-started-local.md b/docs/getting-started-local.md
@@ -232,17 +232,17 @@ AFRAME.registerComponent('spawn-in-circle', {
 
     var angleDeg = angleRad * 180 / Math.PI;
     var angleToCenter = -1 * angleDeg + 90;
-    var rotationStr = '0 ' + angleToCenter + ' 0';
-    el.setAttribute('rotation', rotationStr);
+    angleRad = THREE.MathUtils.degToRad(angleToCenter);
+    el.object3D.rotation.set(0, angleRad, 0);
   },
 
   getRandomAngleInRadians: function() {
-    return Math.random()*Math.PI*2;
+    return Math.random() * Math.PI * 2;
   },
 
   randomPointOnCircle: function (radius, angleRad) {
-    x = Math.cos(angleRad)*radius;
-    y = Math.sin(angleRad)*radius;
+    var x = Math.cos(angleRad) * radius;
+    var y = Math.sin(angleRad) * radius;
     return {x: x, y: y};
   }
 });

diff --git a/examples/js/spawn-in-circle.component.js b/examples/js/spawn-in-circle.component.js
@@ -12,13 +12,11 @@ AFRAME.registerComponent('spawn-in-circle', {
     var circlePoint = this.randomPointOnCircle(this.data.radius, angleRad);
     var worldPoint = {x: circlePoint.x + center.x, y: center.y, z: circlePoint.y + center.z};
     el.setAttribute('position', worldPoint);
-    // console.log('world point', worldPoint);
 
     var angleDeg = angleRad * 180 / Math.PI;
     var angleToCenter = -1 * angleDeg + 90;
     angleRad = THREE.MathUtils.degToRad(angleToCenter);
     el.object3D.rotation.set(0, angleRad, 0);
-    // console.log('angle deg', angleDeg);
   },
 
   getRandomAngleInRadians: function() {