Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transport driver for http #320

Closed
wants to merge 1 commit into from
Closed

Conversation

rslemon
Copy link

@rslemon rslemon commented May 14, 2024

In order to support sending a processed message to http endpoint(e.g: Fluent Bit HTTP input plugin), adding transport driver for http.

Here is example:

$ ./goflow2 -transport=http \
  -transport.http.server=localhost \
  -transport.http.port=4739 \
  -format=json \
  -transport.http.tag=tagname

In order to support sending a processed message to http endpoint(e.g: Fluent Bit HTTP input plugin), adding transport driver for http.

Here is example:

```bash
$ ./goflow2 -transport=http \
  -transport.http.server=localhost \
  -transport.http.port=4739 \
  -format=json \
  -transport.http.tag=tagname
```
@rslemon
Copy link
Author

rslemon commented May 15, 2024

@lspgn Could you please review this PR? Please let me know if there is something that needs to be changed. Thank you.

@lspgn
Copy link
Member

lspgn commented May 17, 2024

Hello @rslemon,
Thank you for your contribution but unfortunately I cannot accept this work.
The readme suggests submitting a feature request first. I rejected a similar PR for an http transport and detailed some of the reasons here: #278 (comment)

Two comments:

  • This would not be scalable as there is no batching.
  • "path" is a preferable term to "tag" but you could pass everything as a single variable called "endpoint".

I would suggest using the standard input to Vector or Fluentbit and convert it to http or a logging system.

@lspgn lspgn closed this May 17, 2024
@lspgn lspgn added the transport Related to transport libraries (Kafka) label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transport Related to transport libraries (Kafka)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants