Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

producer: mpls label, timediff multiplier, time_flow #284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

producer: mpls label, timediff multiplier, time_flow #284

wants to merge 3 commits into from

Conversation

iqbalaydrus
Copy link
Contributor

@iqbalaydrus iqbalaydrus commented Jan 26, 2024 •
edited

This PR fixes 3 bugs:

  • Changing timediff multiplier from 1e9 to 1e6. Based on sysuptime header rfc and LAST_SWITCHED & FIRST_SWITCHED field rfc, everything is in milliseconds instead of seconds.
  • Fixing uint underflow. Some flows do have weird data with SysUptime < (LAST_SWITCHED | FIRST_SWITCHED) which results in incorrect time_flow_start_ns and time_flow_end_ns fields. Check: uint-underflow.pcap.zip
  • Mpls labels when having more than 1 elements will reset the previous value to zero

@iqbalaydrus iqbalaydrus changed the title protection against uint overflow & time unit fix producer: mpls label, timediff multiplier, time_flow Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@iqbalaydrus