[REF] Refactor load_data for gifti images with more than one data array #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the `load_data` function to allow the transformation of GiftiImages with more than one data array (e.g. timeseries data).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
load_datafunction to allow it's use for gifti images with more than one data array (e.g. for timeseries/functional data). There were a few issues with the function, which are related to how theagg_datamethod for GiftiImage objects (from nibabel) handles the intents of data arrays: when the intents of a data array is set toNIFTI_INTENT_TIMESERIES, theagg_datamethod returns a 2D ndarray, but when the intents are something else (e.g.NIFTI_INTENT_SHAPE), then the data arrays are returned as a tuple of multiple 1D array. Theload_datawas not working as expected in either of these cases (i.e. it couldn't load nor stack data images into numpy arrays).This PR should fix Issue #139