Fix random Arbor ArbOS ghost command bug

[kedare]

On many of our production device, Arbor ArbOS would randomly insert the command in the command result, this is a fix for it.

It may be interesting to insert the fix also in the commands run in compliances and others, would making this new function global in the .js and calling is in runCommand works ?

[SCadilhac]

I didn't see the issue in some testing. Are you sure it's really the device sending back the command? Can you take a debug snapshot (https://github.com/netfishers-onl/Netshot/wiki/Snapshot-troubleshooting) to confirm?
By the way, don't you want to add parsing of the hardware block to extract the part number and serial number?

[kedare]

All our instances are running in VM so I cannot have the proper output to add support for modules on my side (but I already get the "device/vm" serial number properly).

I confirm you that this bug is appearing when doing snapshot on all our (VM) instances quite randomly, almost half the time when running the 1.0 driver, and never happens wiht 1.1

I tried the snapshot with debug mode as said in the doc you pointed but the snapshots never ends (keep consuming 100% cpu on 2 cores, had to restart netshot after 5 minutes, the last log I get is Ssh$JschLogger: Authentication succeeded (password).)

[kedare]

Do you have the same issue with debug mode ? I cannot test more because of this.