Set up initial Mypy configuration for type checking #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plan is to have full static type/type hint coverage in the codebase, this is a first step towards that goal. Some module-level variables needed types right away so that's included in this patch.
|
I think it'll be easiest to park this until Python 3.7 support is dropped as recent Mypy versions only support Python 3.8+. |
|
Are there any plans for when this will move forward since Python 3.7 is end of life as of last summer? |
|
@ogenstad yeah, I need to make a small release with some bug fixes first but then we're good to drop Python 3.7 support and get this thing going. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to have full static type/type hint coverage in the codebase, this is a first step towards that goal.
Some module-level variables needed types right away so that's included in this patch.
Including IPython in dev dependencies because we import it in the netaddr.cli module and Mypy would complain otherwise when we get to providing type hints in the module.