Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing MPI tests not properly detected #3155

Closed
heplesser opened this issue Mar 15, 2024 · 1 comment · Fixed by #3187
Closed

Failing MPI tests not properly detected #3155

heplesser opened this issue Mar 15, 2024 · 1 comment · Fixed by #3187
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Critical Needs to be addressed immediately stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Build system and CI

Comments

@heplesser
Copy link
Contributor

It appears that if tests in the testsuite/mpi/{2,3,4} directories fail (at least if failing due to a failed assertion), then the corresponding rows in the test report will miss instead of reporting failures, and the testsuite reports overall a passing result.

I mark this critical because it invalidates the results of our CI.
@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Critical Needs to be addressed immediately I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 15, 2024
@heplesser heplesser added this to To do in Build system and CI via automation Mar 15, 2024
@heplesser heplesser mentioned this issue Apr 22, 2024
Merged
@github-actions GitHub Actions
Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 15, 2024
@gtrensch gtrensch moved this from To do to In progress in Build system and CI May 17, 2024
Build system and CI automation moved this from In progress to Done Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Critical Needs to be addressed immediately stale Automatic marker for inactivity, please have another look here T: Bug Wrong statements in the code or documentation
Projects
Build system and CI
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make test log parsing more robust heplesser/nest-simulator
1 participant
@heplesser