Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surf on win32 builds #2567

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

aliceisjustplaying
Copy link
Collaborator

@aliceisjustplaying aliceisjustplaying commented May 5, 2024

surf defaults to HTTPS however the TIC-80 website uses a modern certificate that's not available (by default at least) on old systems, thus we default to plain http on the 32-bit build.

Tested on a Thinkpad x220 running Windows XP (32-bit) / Windows 7 (32-bit).

Old build on the left, fix on the right.

surf-winxp

surf-win7-fix

Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@nesbox nesbox added this to In progress in dev version 1.2 via automation May 5, 2024
@nesbox nesbox added the bug label May 5, 2024
@nesbox nesbox merged commit dc4d377 into nesbox:main May 5, 2024
33 checks passed
dev version 1.2 automation moved this from In progress to Done May 5, 2024
aliceisjustplaying added a commit to aliceisjustplaying/TIC-80 that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants