refactor(options): generate available options values from lua #28659
Conversation
github-actions
bot
added
the
build
github-actions
bot
added
refactor
| local gen_values = options_file:find('options_values') and true or false | ||
|
|
There was a problem hiding this comment.
I don't like this pattern of using the same generator for 2 completely different purposes. Use a separate generator file for this, similar to what gen_options_enum.lua does
There was a problem hiding this comment.
These are not "complete different purposes". And why is gen_options_enum.lua in a separate file?
There was a problem hiding this comment.
These are not "complete different purposes".
The script does two very different things depending on which file it's being called on, that seems different to me. A script's behavior depending on the filename is certainly not ideal.
And why is
gen_options_enum.luain a separate file?
Precisely because it does a completely different thing. gen_options generates the options[] array, gen_options_enum generates the option index enum (using information from the options[] array, so order matters here) and the hash table for findoption()
glepnir
force-pushed
the
ref_opt_values
branch
4 times, most recently
from
8920fd4
to
340517c
Compare
Problem: currently the available values of options is split from options meta lua file. Solution: generate it from lua file.
Problem: currently the available values of options is split from options meta lua file.
Solution: generate it from lua file.