New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configurable contrast and gamma #2510
Conversation
089dc0b
to
9207f19
Compare
For a technical overview of what this actually does, see: |
Full hinting is a bit too aggressive, especially with fractional font sizes
9207f19
to
49f5096
Compare
I think the default hinting needs to be changed to On Linux, Wayland at least on my monitor, I often prefer slight due to the slightly improved quality, but I think none is OK on that as well. |
I changed the default hinting to |
* Configurable text contrast and gamma * Explicitly specify the colorspace to use * Change default hinting to slight Full hinting is a bit too aggressive, especially with fractional font sizes * Update the documentation * Cargo fmt * Set font hinting none as default --------- Co-authored-by: Kaylee Simmons <kay@the-simmons.net> # Conflicts: # website/docs/configuration.md
What kind of change does this PR introduce?
A recent Skia update made it possible to configure the gamma and the contrast of the rendered text. So this makes that configurable from the Neovide side. The defaults have been chosen to give readable text on all backgrounds and an accurate color representation. But it can be changed to be similar to your favourite terminal for example.
Here are some screenshots for comparison (make sure to open the images in full size)
Neovide main (with fractional font size support (#2500)
This PR
Alacritty
Wezterm
Kitty
Foot
Neovide emulating alacritty (gamma 0.8, contrast 0.1)
As you can see different terminals render the text very differently. And IMO Neovide has always been among the better ones, especially when you take into account different colors and backgrounds, and that further improves it.
The default hinting has also been changed from full to slight. Full makes the text too bold, and sometimes distorts the text too much.
Closes these for good
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
Notes