feat: Implement bell #2469
feat: Implement bell #2469
Conversation
|
Another option for the bell is to use a configurable external command like Alacritty: That's probably the only easy way on X11/Wayland. On Windows and macOS it could still default to built-ins like you do here, but allow a command for more customization. |
|
I've added |
Sorry for not coming back to you earlier. Supporting vectors is indeed not supported by our settings system right now. But I think a single command is good enough. You can always call a shell script if you want a more complex command. |
| } | ||
| RedrawEvent::VisualBell => { | ||
| tracy_zone!("EditorVisualBell"); | ||
| // TODO: Implement visual bell |
There was a problem hiding this comment.
Do you need help implementing this?
| let bell_command = bell_command.split(" ").collect::<Vec<_>>(); | ||
| if bell_command.is_empty() { | ||
| unsafe { | ||
| // TODO: How to bell on X11/Wayland? |
There was a problem hiding this comment.
You can change this command to "Only custom commands are supported on X11 and Wayland"
What kind of change does this PR introduce?
Implement bell sound on macOS and Windows.
Close #1967 (currently partial)
TODO
neovide.bellrpc method for user?Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.