feat: add support of Metal renderer on macOS. #2461
Conversation
Cargo.toml
Outdated
| [target.'cfg(target_os = "macos")'.dependencies] | ||
| icrate = { version = "0.0.4", features = [ "apple", "Foundation", "Foundation_NSThread", "AppKit", "AppKit_NSColor", "AppKit_NSEvent", "AppKit_NSView", "AppKit_NSWindow", "AppKit_NSViewController", "AppKit_NSMenu", "AppKit_NSMenuItem", "AppKit_NSOpenPanel", "AppKit_NSScreen", "Foundation_NSArray" ] } | ||
| objc2 = "0.4.1" | ||
| metal = "0.27.0" | ||
| skia-safe = { version = "0.68.0", features = ["metal", "gl", "textlayout"] } |
There was a problem hiding this comment.
It think you should be able to use the standard gl, textlayout, feature here. We don't use anything from the metal and gl features, even if the rendering is done through that.
There's no metal, gl, textlayout binary combination as far as I can see https://github.com/rust-skia/skia-binaries/releases, so it would slow down the compilation.
There was a problem hiding this comment.
Though there is no metal, gl, textlayout combination there, this is exactly what we want. Just like on Windows, there are two renderer, OpenGL and D3D. There are also two renderer, OpenGL and Metal on macOS. Without either one, it does not compile.
I don't know why there is no such combination. Maybe due to OpenGL is obsolete on macOS.
There was a problem hiding this comment.
I was probably wrong, and it's indeed needed. I remembered wrong how it was done on Window.
I guess we have to ask for binaries from skia-safe then.
There was a problem hiding this comment.
It's OK.
The compilation does not fail. It will build skia from scratch and use it. Though I never experienced using a pre-compiled binary on my machine. It always build from scratch.
crupest
force-pushed
the
metal
branch
3 times, most recently
from
ab31911
to
fc6e0a0
Compare
crupest
force-pushed
the
metal
branch
3 times, most recently
from
10fb26b
to
69e3553
Compare
Add Metal renderer on macOS.
Currently this is a very naive implementation. I created this pr when the window at least shows things. I'm very unfamiliar with Metal development. So if you have any advice, I will extremely appreciate it.