fix: Maximize window on creation on linux #2454
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code notes a flickering issue when creating the window in a maximized state, but I haven't been able to reproduce this flicking on any Linux environment. I tested GNOME, KDE, and sway, and none of them exhibited any flickering. I therefore changed the behavior so that the window is maximized on creation in accordance with persistent window settings or config file/command.
This also resolves the mild annoyance of the window existing in a blank, non-maximized state for a short while before initialization is finished, since set_visible has no effect on Wayland
TODO: More X11 testing
What kind of change does this PR introduce?
Did this PR introduce a breaking change?