Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention winget as an installation option #2451

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kbarnes3
Copy link

What kind of change does this PR introduce?

  • Documentation

Did this PR introduce a breaking change?

  • No

Details

WinGet has an up to date installer for Neovide and WinGet is the only package manager to come preinstalled on Windows (for some newer versions at least). This change updates the website documentation to list that as an installation option.

@fredizzimo
Copy link
Member

The main reason we don't instructions for winget is that we haven't found a maintainer that regularly updates it, so the versions often lag behind as you probably noticed when you updated it to 0.12.2 yesterday.

We have been considering making the updates part of our release process, but so far, no actions have been taken.

@kbarnes3
Copy link
Author

Thanks for the context there. Yeah, pointing to a package manager that will often be stale wouldn't be great. That said, the Neovide update I did in winget was my first winget contribution and I did find it pretty quick and easy. My WinGet PR was generated by wingetcreate. I ran it in interactive mode with this command:

 wingetcreate update Neovide.Neovide -i -v 0.12.2 

But I believe there are flags to support usage in a Pipeline. I don't know anything about Neovide's release process, so no clue about how easy it is to integrate. I'm happy to help manually publish updates to Winget if needed though.

@Kethku
Copy link
Member

Kethku commented Apr 23, 2024

Thanks for the context there. Yeah, pointing to a package manager that will often be stale wouldn't be great. That said, the Neovide update I did in winget was my first winget contribution and I did find it pretty quick and easy. My WinGet PR was generated by wingetcreate. I ran it in interactive mode with this command:

 wingetcreate update Neovide.Neovide -i -v 0.12.2 

But I believe there are flags to support usage in a Pipeline. I don't know anything about Neovide's release process, so no clue about how easy it is to integrate. I'm happy to help manually publish updates to Winget if needed though.

Sorry for the slow reply. My two cents is that if youre up to working on automating or manually updating the winget package, that would be great. Before we update the docs to mention winget though it seems like it would be good to build confidence that it will consistently be updated. The worst situation would be if we call out winget in the docs and then it falls behind.

Maybe this PR could get combined with one that adds something to https://github.com/neovide/neovide/blob/main/.github/workflows/release.yml to do the push? Such a PR should also update the contributor documentation to outline any tasks that would need to be manually done. Once those are done I see no reason not to merge this

@kbarnes3
Copy link
Author

@Kethku I've extended release.yml to automatically create the winget PR. There are two main caveats:

  1. I can't fully test this end to end. I did run all the PowerShell commands locally and they seem to work as I'd expect.
  2. Someone will need to create an NV_WINGET secret with a GitHub PAT that has public_repo permissions. See https://github.com/microsoft/winget-create?tab=readme-ov-file#github-personal-access-token-classic-permissions for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants