[BUGFIX] - fix creationDate sorting #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # composer.json
TASK: declare compatibility to Neos 9
…y-path FEATURE: add own translation label for clipboard button
…r from creationDate to creationDateTime in order to make sorting work
Sebobo
requested changes
Mar 20, 2024
| "php": ">=7.4", | ||
| "neos/redirecthandler": "~5.0 || dev-main", | ||
| "neos/neos": "~7.3 || ~8.0 || dev-master", | ||
| "php": ">= 8.2", |
There was a problem hiding this comment.
I think you based your change on the incorrect branch. Please make sure your commit is on top of the 2.x branch and not on the neos 9 branch.
There was a problem hiding this comment.
I'll close this pull request and submit a new one with the proper base branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sorting by creationDate leads to unexpected UI behaviour (not sorting correctly and weird switch to detail view).
Changed creation date time identifier in renderColumnHeader from creationDate to creationDateTime in order to make sorting work.