Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Correctly migrate Neos\ContentRepository\Utility #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 2, 2024

... at least partially ... to 100% equivalent would be to cast that to a string now but idk how.

NodeName::fromString($stuff)->value;

@kdambekalns
Copy link
Member

Ok, once this ran, there is no chance to detect the places that woud still need a string cast. That might not be an issue, but when struct typing is in effect, it woud create hard-to-find bugs.

Any Rector expert that knows how we could "chain" changes and add the ->value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants