TASK: Adjust to changes in Neos removing internal node properties #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linting seems again unrelated :/ |
|
These errors seem unrelated |
grebaldi
reviewed
Apr 19, 2024
|
Oh, and also: phpstan is green locally |
mhsdesign
reviewed
May 9, 2024
| '_hidden' => $node->tags->contain(SubtreeTag::fromString('disabled')), | ||
| '_hiddenInIndex' => $node->getProperty('_hiddenInIndex'), | ||
| // TODO: we should export this correctly named, but that needs changes throughout the JS code as well. | ||
| '_hidden' => $node->tags->withoutInherited()->contain(SubtreeTag::disabled()), |
There was a problem hiding this comment.
ah i see nice fix here ;) this is currently broken as nodes are always shown as explicitly hidden
mhsdesign
reviewed
May 9, 2024
Comment on lines
+185
to
+187
| // !!! REMEMBER: we are not allowed to use $node anymore, | ||
| // because it may have been modified by the commands above. | ||
| // Thus, we need to re-fetch it (as a workaround; until we do not need this anymore) |
There was a problem hiding this comment.
Suggested change
| // !!! REMEMBER: we are not allowed to use $node anymore, | |
| // because it may have been modified by the commands above. | |
| // Thus, we need to re-fetch it (as a workaround; until we do not need this anymore) | |
| // We have to refetch the Node after modifications because its a read-only model | |
| // These 'Change' classes have been designed with mutable Neos < 9 Nodes and thus this might seem hacky | |
| // When fully redesigning the Neos Ui php integration this will fixed |
mhsdesign
reviewed
May 9, 2024
Comment on lines
+172
to
+173
| $propertyName === '_nodeType' => $this->handleNodeTypeChange($workspace, $subject, $propertyName), | ||
| $propertyName === '_hidden' => $this->handleHiddenPropertyChange($workspace, $subject, $propertyName), |
There was a problem hiding this comment.
Suggested change
| $propertyName === '_nodeType' => $this->handleNodeTypeChange($workspace, $subject, $propertyName), | |
| $propertyName === '_hidden' => $this->handleHiddenPropertyChange($workspace, $subject, $propertyName), | |
| // todo create custom 'changes' for these special cases | |
| // we continue to use the underscore logic in the Neos Ui code base as the JS-client code works this way | |
| $propertyName === '_nodeType' => $this->handleNodeTypeChange($workspace, $subject, $propertyName), | |
| $propertyName === '_hidden' => $this->handleHiddenPropertyChange($workspace, $subject, $propertyName), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: neos/neos-development-collection#4921