Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Adjust to changes in Neos removing internal node properties #3735

Merged
merged 5 commits into from May 14, 2024

Conversation

kitsunet
Copy link
Member

@kitsunet kitsunet commented Mar 7, 2024

@kitsunet
Copy link
Member Author

kitsunet commented Mar 7, 2024

linting seems again unrelated :/

@kitsunet
Copy link
Member Author

These errors seem unrelated

Copy link
Contributor

@grebaldi grebaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kitsunet,

I ran E2E tests locally and did some manual testing on disabled-state, and hiddenInMenu stuff. Works perfectly 👍

@grebaldi
Copy link
Contributor

Oh, and also: phpstan is green locally

'_hidden' => $node->tags->contain(SubtreeTag::fromString('disabled')),
'_hiddenInIndex' => $node->getProperty('_hiddenInIndex'),
// TODO: we should export this correctly named, but that needs changes throughout the JS code as well.
'_hidden' => $node->tags->withoutInherited()->contain(SubtreeTag::disabled()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see nice fix here ;) this is currently broken as nodes are always shown as explicitly hidden

@mhsdesign mhsdesign merged commit 7204013 into 9.0 May 14, 2024
8 of 10 checks passed
@mhsdesign mhsdesign deleted the task/4208-remove-internal-node-properties branch May 14, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants