BUGFIX: Neos Ui JSON serializable property values #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports neos/neos-development-collection#4638 to the Neos Ui, as the class was moved in Neos 9. Original commit message: This bugfix will make use of the \JsonSerializable interface instead directly when serializing properties for the neos ui. With neos/flow-development-collection#2762 native support for vo's in `flow_json_array` was introduced. That also allows value object support for node properties, as they can be stored directly the node properties flow_json_array. Unfortunately the property serialisation for the NeosUi does NOT use the expected `\JsonSerializable::jsonSerialize` but the property mapper and the `ArrayFromObjectConverter` for object types to get an array that will be json encoded. This works mostly fine but in some cases it fails: - when your `fromArray` fields and property names values dont match - when a "object" subtypes the object mapper is no convertable like the `GuzzleHttp\Psr7\Uri`: ``` Too few arguments to function GuzzleHttp\Psr7\Uri::isAbsolute(), 0 passed in /core/neos-manufacture-highest/Packages/Framework/Neos.Utility.ObjectHandling/Classes/ObjectAccess.php on line 151 and exactly 1 expected ``` Current workarounds are aop: https://github.com/sitegeist/Sitegeist.InspectorGadget/blob/78f5f4a206287b1c4bedf5cb88582ed51cb4a311/Classes/Infrastructure/NodeInfo/NodeInfoPostProcessingAspect.php#L17 Or to use a dumb property mapper: https://github.com/sitegeist/Sitegeist.Archaeopteryx/blob/9322b9cb8e4824bcaf7aaa247c23b1244a2f1167/Classes/LinkToArrayForNeosUiConverter.php#L12C16-L12C78
mhsdesign
commented
Feb 19, 2024
| if ( | ||
| $propertyValue instanceof \JsonSerializable | ||
| // todo maybe combine them for performance with a static `isDenormalizable` utility. | ||
| && (new ValueObjectArrayDenormalizer())->supportsDenormalization([], $propertyValue::class) |
There was a problem hiding this comment.
and neos/flow-development-collection#2766 seems to be missing as a feature for the new cr...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports neos/neos-development-collection#4638 to the Neos Ui, as the class was moved in Neos 9.
What I did
How I did it
How to verify it