Bugfix/3477 infinite loading indicator #3714
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is a bit flaky" This reverts commit 956cdf8.
|
🎥 End-to-End Test Recordings These videos demonstrate the end-to-end tests for the changes in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3477
Alternate fix replaces #2566 which is good and we need to make the page handler non neos ui specific so it can go "back" to neos
The initial idea to spin until the ui informs to be ready was that if possibly a lot of ckeditors have to be initialised and that the content manager should wait until the indicator stops spinning before clicking around.
IN my problems i could not verify that and as this is just an indicator it does no harm stopping a few milliseconds earlier. It never prevented anything or is used for anything critical.
In fact the infinite spinning indicator is much worse when developing and debugging
What I did
How I did it
How to verify it