Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Show resize icon on safari for document tree #3581

Open
wants to merge 2 commits into
base: 8.3
Choose a base branch
from

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Jul 13, 2023

What I did

Both resize icons for the left sidebar are now visible (functionality was always there only invisible)

Resolves: #3556

How I did it

Removed the background color from the tree component itself and instead set the background colours of the parent component that define the resize option.

How to verify it

Check in all browsers whether the resize icons all properly show up.

@Sebobo Sebobo added Bug Label to mark the change as bugfix 8.3 labels Jul 13, 2023
@crydotsnake crydotsnake linked an issue Jul 13, 2023 that may be closed by this pull request
Copy link
Member

@crydotsnake crydotsnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resize icon is visible. But for a reason i still cant resize the document tree. I dont think I'm too stupid too catch it 🤔

But maybe this is something for another PR since this was only about the icon (?)

resize-document-tree.mov

@Sebobo
Copy link
Member Author

Sebobo commented Jul 13, 2023

@crydotsnake can you give more details about your browser and version?

@crydotsnake
Copy link
Member

@crydotsnake can you give more details about your browser and version?

Safari Version 16.5.1

@Sebobo
Copy link
Member Author

Sebobo commented Jul 13, 2023

Ah thx, I can reproduce the issue when the window height is quite small. I will check. This fix doesn't make sense without fixing this too.

@mhsdesign mhsdesign marked this pull request as draft August 28, 2023 12:19
@markusguenther
Copy link
Member

I could make the resize work in safari, but the Icons are still pretty small, and it is no good UX to resize the trees in Safari. In other browsers, it still works fine.

Sebobo and others added 2 commits December 16, 2023 20:50
The icon was not visible due to the background color of the tree component.

Resolves: #3556
@markusguenther markusguenther force-pushed the bugfix/3556/show-resize-icon-on-safari branch from 3356f39 to 0f4134a Compare December 16, 2023 19:51
@markusguenther
Copy link
Member

Ok, acceptance tests now also work :)

@Sebobo Sebobo marked this pull request as ready for review December 20, 2023 10:06
@Sebobo
Copy link
Member Author

Sebobo commented Dec 20, 2023

Will test again

@Sebobo
Copy link
Member Author

Sebobo commented Dec 20, 2023

I could make the resize work in safari, but the Icons are still pretty small, and it is no good UX to resize the trees in Safari. In other browsers, it still works fine.

But now the whole tree incl. the topbar scrolls? That's also wrong

@Sebobo
Copy link
Member Author

Sebobo commented Dec 20, 2023

So I tried a few things. The main problem is that Safari uses a higher z-index for the scrollbar of the page tree subcomponent than for the resize icon of the parent container and they overlap. I tried the trick from https://stackoverflow.com/questions/21684101/css-vertical-scrollbar-padding-left-right-in-ul-possible but that didn't work properly either.

What works is to add a padding to leftSideBar__top which makes the icon work, but scrolling looks strange then... not sure if we can fix this without Safari being fixed 🤷🏻‍♂️

@mhsdesign
Copy link
Member

Hi whats the status on this one? We found out that the autoprefixer for safari wasn't working so maybe this is related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix next-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Document and Content tree not resizable on safari
4 participants