TASK: cleanup disabled autoparagraph mode #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
changed the title
grebaldi
approved these changes
Jul 5, 2023
packages/neos-ui-ckeditor5-bindings/src/cleanupContentBeforeCommit.spec.js
Outdated
Show resolved
Hide resolved
crydotsnake
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the fix at #3532 was the most correct one in terms of behaviour its also the hardest one to maintain over time. And brought a regression see #3558.
@grebaldi had the idea to simplify the optional cleanup.
In the disabled paragraph mode (which is now also named in the code like this, in preparation for #3553) we still trim the outer span, but in case there was another span somewhere we return the original content (so we dont ever run into this: #2918)
What I did
How I did it
How to verify it