Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: set new-password in EditAccount page #5017

Merged
merged 2 commits into from Apr 27, 2024
Merged

TASK: set new-password in EditAccount page #5017

merged 2 commits into from Apr 27, 2024

Conversation

laurahaenel
Copy link
Collaborator

@laurahaenel laurahaenel commented Apr 26, 2024 •
edited

Solves #4944

Upgrade instructions

Not needed

Review instructions

Allow your password manager to autofill everything on page load.
The password field (for setting new password) will not be autofilled.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@laurahaenel laurahaenel marked this pull request as ready for review April 26, 2024 15:53
dlubitz
dlubitz approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks. Looks good!

mhsdesign
mhsdesign approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@bwaidelich bwaidelich merged commit b623608 into neos:8.3 Apr 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

@dlubitz dlubitz dlubitz approved these changes

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees
No one assigned
Labels
8.3 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laurahaenel @bwaidelich @dlubitz @mhsdesign