TASK: Cleanup EventNormalizer
#5016
Conversation
Add `EventNormalizer::normalize()` and make `getEventData()` and `getEventType()` private
| $this->eventNormalizer->getEventType($event)->value, | ||
| json_decode($this->eventNormalizer->getEventData($event)->value, true), | ||
| [] | ||
| $normalizedEvent->id->value, |
There was a problem hiding this comment.
i guess this is a functional change as in that we now have stable ids in the export.
Probably a good idea so we have less diff if exporting twice and having the export in version control like the Neos.Demo
There was a problem hiding this comment.
It's the same as before (I think). The normalizer will create the id (unless its a decorated event that already has one)
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah i see you're right a bit sneaky i see ^^ (We are sure at that time that its not a decorated event ... thats why it works)
There was a problem hiding this comment.
Okay in that case i guess its a bit weird that normalise is not pure and will return different results on succeeding calls. But the behaviour is not new and required already at other places (we just seem to share the code here now)
So 👍 feel free to merge this ;)
There was a problem hiding this comment.
Even if it was and even if it would specify the id it would work as long as the id is unique
bwaidelich
changed the title
EventNormalizerEventNormalizer
| $this->eventNormalizer->getEventType($event)->value, | ||
| json_decode($this->eventNormalizer->getEventData($event)->value, true), | ||
| [] | ||
| $normalizedEvent->id->value, |
There was a problem hiding this comment.
Add
EventNormalizer::normalize()and makegetEventData()andgetEventType()private