New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! TASK: Remove magic underscore access for internal node properties #5015
base: 9.0
Are you sure you want to change the base?
!!! TASK: Remove magic underscore access for internal node properties #5015
Conversation
As we don't support property('_hidden') there would be no way to figure out if a node is hidden.
…nd filter FlowQuery Fixes neos#4208 (comment)
one todo is: how to sort by creation date in Neos 9?? Something like node.timestamps.originalCreated in our weekly from the 26. we discussed that instead of adding a new flowquery or a magic parameter, we probably want to support the old legacy 8.3 syntax The question is if these modifiers should only work for the |
another todo is: as we relocate the sort operation to the other flow-queries and touch its logic i seem to have to carry out the burden to migrate the old functional test https://github.com/neos/neos-development-collection/blob/fe0063b7e4fbaea9b0a72abfd323354fabf42173/Neos.Neos/Tests/Functional/FlowQueryOperations/SortOperationTest.php to behat. |
it will be fully migrated via #5015 (comment)
I do not understand why you did this? |
That was what i have been discussing in #4208 or in the meetings i thought but it seems we have talked past each other? My thesis in short: We have the
While these are the ones known from 8.3
The actual important and ones used in 8.3 like To avoid confusion about which magic underscore properties still exist in 9.0 a simple way is - it thought we agreed upon this in the meeting from the 19.01 link - to NOT have any underscore property logic and remove any magic from this syntax. Like one can use an underscore now in consumer land but it is never any more special than any other character. Thats why this pr remove partially implemented legacy support for There is a little but as discussed in on the 26.04 we concluded to still allow sorting nodes by date via the |
This is all clear, but
why, why didn't you just add the things missing to my original PR? |
Because i thought it would get too complex and the |
Too much going on LOL, seems still a bit weird but 🤷 |
it will be fully migrated via neos/neos-development-collection#5015 (comment)
Resolves: #4208
Related: #4921
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions