Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! BUGFIX: Fix schema of hierarchy relation table #5009

Merged
merged 1 commit into from Apr 24, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Apr 24, 2024

Partially reverts #4790 that changed the indexes of the cr_<crid>_p_graph_hierarchyrelation table.

Note that this needs a ./flow cr:setup and ./flow cr:projectionreplay --projection contentGraph

@github-actions github-actions bot added the 9.0 label Apr 24, 2024
@mhsdesign
Copy link
Member Author

performance tests:

9.0: super sloooow

reverting just the primary key adjustments of line 68: #4790 (comment)

4.42s user 1.86s system 16% cpu 37.674 total
4.75s user 1.97s system 17% cpu 38.736 total
5.37s user 2.18s system 18% cpu 40.325 total

reverting #4790 fully

4.42s user 1.83s system 16% cpu 38.628 total
4.40s user 1.84s system 16% cpu 37.995 total
4.51s user 1.86s system 16% cpu 38.764 total

@bwaidelich bwaidelich changed the title Revert "Merge pull request #4790 from kitsunet/task/split-dimensionsp… BUGFIX: Fix schema of hierarchy relation table Apr 24, 2024
@github-actions github-actions bot added the Bug label Apr 24, 2024
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by testing & reading.

As suggested we should investigate, why this change was a regression. And maybe we can re-add it in a slightly different form

@bwaidelich
Copy link
Member

@mhsdesign can you remove the draft status?

@mhsdesign mhsdesign marked this pull request as ready for review April 24, 2024 16:00
@mhsdesign
Copy link
Member Author

Sure i just want to require @kitsunet's review on this one :)

@mhsdesign mhsdesign requested a review from kitsunet April 24, 2024 16:01
@mhsdesign
Copy link
Member Author

mhsdesign commented Apr 24, 2024

As per @kitsunet's message via slack

Yeah merge the removal and then let’s check soonish what an actual primary key could look like and why this isn’t

i consider this approved

Followup ticket: #5011

@mhsdesign mhsdesign changed the title BUGFIX: Fix schema of hierarchy relation table !!! BUGFIX: Fix schema of hierarchy relation table Apr 24, 2024
@mhsdesign mhsdesign merged commit 5d855d3 into neos:9.0 Apr 24, 2024
13 checks passed
@mhsdesign mhsdesign deleted the bugfix/revert-4790 branch May 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants