FEATURE: ContentGraphAdapter for write side access #4979
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| <?php | ||
|
|
||
| namespace Neos\ContentGraph\DoctrineDbalAdapter; | ||
|
|
||
| use Doctrine\DBAL\Connection; | ||
| use Neos\ContentGraph\DoctrineDbalAdapter\Domain\Repository\DimensionSpacePointsRepository; | ||
| use Neos\ContentGraph\DoctrineDbalAdapter\Domain\Repository\NodeFactory; | ||
| use Neos\ContentRepository\Core\Feature\ContentGraphAdapterFactoryInterface; | ||
| use Neos\ContentRepository\Core\Feature\ContentGraphAdapterInterface; | ||
| use Neos\ContentRepository\Core\Infrastructure\Property\PropertyConverter; | ||
| use Neos\ContentRepository\Core\NodeType\NodeTypeManager; | ||
| use Neos\ContentRepository\Core\SharedModel\ContentRepository\ContentRepositoryId; | ||
| use Neos\ContentRepository\Core\SharedModel\Workspace\ContentStreamId; | ||
| use Neos\ContentRepository\Core\SharedModel\Workspace\WorkspaceName; | ||
|
|
||
| /** | ||
| * Factory for the ContentGraphAdapter implementation for doctrine DBAL | ||
| * | ||
| * @internal | ||
| */ | ||
| class ContentGraphAdapterFactory implements ContentGraphAdapterFactoryInterface | ||
| { | ||
| private NodeFactory $nodeFactory; | ||
|
|
||
| private string $tableNamePrefix; | ||
|
|
||
| public function __construct( | ||
| private readonly Connection $dbalConnection, | ||
| private readonly ContentRepositoryId $contentRepositoryId, | ||
| NodeTypeManager $nodeTypeManager, | ||
| PropertyConverter $propertyConverter | ||
| ) { | ||
| $this->tableNamePrefix = DoctrineDbalContentGraphProjectionFactory::graphProjectionTableNamePrefix( | ||
| $contentRepositoryId | ||
| ); | ||
|
|
||
| $dimensionSpacePointsRepository = new DimensionSpacePointsRepository($this->dbalConnection, $this->tableNamePrefix); | ||
| $this->nodeFactory = new NodeFactory( | ||
| $contentRepositoryId, | ||
| $nodeTypeManager, | ||
| $propertyConverter, | ||
| $dimensionSpacePointsRepository | ||
| ); | ||
| } | ||
|
|
||
| public function create(WorkspaceName $workspaceName, ContentStreamId $contentStreamId): ContentGraphAdapterInterface | ||
| { | ||
| return new ContentGraphAdapter($this->dbalConnection, $this->tableNamePrefix, $this->contentRepositoryId, $this->nodeFactory, $workspaceName, $contentStreamId); | ||
| } | ||
|
|
||
| public function createFromContentStreamId(ContentStreamId $contentStreamId): ContentGraphAdapterInterface | ||
| { | ||
| return new ContentGraphAdapter($this->dbalConnection, $this->tableNamePrefix, $this->contentRepositoryId, $this->nodeFactory, null, $contentStreamId); | ||
| } | ||
|
|
||
| public function createFromWorkspaceName(WorkspaceName $workspaceName): ContentGraphAdapterInterface | ||
| { | ||
| return new ContentGraphAdapter($this->dbalConnection, $this->tableNamePrefix, $this->contentRepositoryId, $this->nodeFactory, $workspaceName, null); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?php | ||
|
|
||
| namespace Neos\ContentGraph\DoctrineDbalAdapter; | ||
|
|
||
| use Neos\ContentRepository\Core\Feature\ContentGraphAdapterFactoryBuilderInterface; | ||
| use Neos\ContentRepository\Core\Feature\ContentGraphAdapterFactoryInterface; | ||
| use Neos\ContentRepository\Core\Infrastructure\DbalClientInterface; | ||
| use Neos\ContentRepository\Core\Infrastructure\Property\PropertyConverter; | ||
| use Neos\ContentRepository\Core\NodeType\NodeTypeManager; | ||
| use Neos\ContentRepository\Core\SharedModel\ContentRepository\ContentRepositoryId; | ||
|
|
||
| /** | ||
| * Builder to combine injected dependencies and ProjectionFActoryDependencies into a ContentGraphAdapterFactory | ||
| * @internal | ||
| */ | ||
| class ContentGraphAdapterFactoryBuilder implements ContentGraphAdapterFactoryBuilderInterface | ||
|
There was a problem hiding this comment. I wouldn't mind getting around having this, and am happy for suggestions, I don't really see it though. An ugly option would be to to have something along the lines of:
and the There was a problem hiding this comment. AFAIS we only need it to pass in There was a problem hiding this comment. ..or even make the |
||
| { | ||
| public function __construct(private readonly DbalClientInterface $dbalClient) | ||
| { | ||
| } | ||
|
|
||
| public function build(ContentRepositoryId $contentRepositoryId, NodeTypeManager $nodeTypeManager, PropertyConverter $propertyConverter): ContentGraphAdapterFactoryInterface | ||
| { | ||
| return new ContentGraphAdapterFactory($this->dbalClient->getConnection(), $contentRepositoryId, $nodeTypeManager, $propertyConverter); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?php | ||
| namespace Neos\ContentGraph\DoctrineDbalAdapter; | ||
|
|
||
| /** | ||
| * Encapsulates table name generation for content graph tables | ||
| * @internal | ||
| */ | ||
| final class ContentGraphTableNames | ||
| { | ||
| private function __construct(private readonly string $tableNamePrefix) | ||
| { | ||
| } | ||
|
|
||
| public static function withPrefix(string $tableNamePrefix): self | ||
| { | ||
| return new self($tableNamePrefix); | ||
| } | ||
|
|
||
| public function node(): string | ||
| { | ||
| return $this->tableNamePrefix . '_node'; | ||
| } | ||
|
|
||
| public function hierachyRelation(): string | ||
| { | ||
| return $this->tableNamePrefix . '_hierarchyrelation'; | ||
| } | ||
|
|
||
| public function dimensionSpacePoints(): string | ||
| { | ||
| return $this->tableNamePrefix . '_dimensionspacepoints'; | ||
| } | ||
|
|
||
| public function referenceRelation(): string | ||
| { | ||
| return $this->tableNamePrefix . '_referencerelation'; | ||
| } | ||
|
|
||
| public function checkpoint(): string | ||
| { | ||
| return $this->tableNamePrefix . '_checkpoint'; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should refine this naming