BUGFIX: Sort properties in raw content mode #4957
Conversation
| @@ -1,7 +1,12 @@ | |||
| prototype(Neos.Neos:RawContent.NodeProperties) < prototype(Neos.Fusion:Component) { | |||
| @private { | |||
| items = ${node.nodeType.properties} | |||
| items.@process.sort = ${Neos.Ui.PositionalArraySorter.sort(value, 'ui.inspector.position')} | |||
There was a problem hiding this comment.
sorry nope :D
Neos.Ui.PositionalArraySorter.sort is ONLY for the NeosUi bootstrap and was cleaned up wiht 9.0.x
Also we should not introduce another dependency to the Ui in Neos.Neos see #4951
There was a problem hiding this comment.
Ah right sorry, completely overlooked that 🤦
Sooooooo another Helper in Neos then?
There was a problem hiding this comment.
Yeah or we use Neos.Array and put there a positional helper on it and mark it as internal (the whole helper is internal / experimental)
There was a problem hiding this comment.
I made the adjustments and added the sorting method via the Neos.Array helper.
Sebobo
force-pushed
the
bugfix/sort-raw-content-properties
branch
from
14c74cf
to
0ee0be1
Compare
| /** | ||
| * Sorts the input array by the $positionProperty of each element. | ||
| */ | ||
| public function sortByPosition(array $set, $positionPropertyPath = 'position'): array |
There was a problem hiding this comment.
I would suggest to call this one sortByKey or sortBy instead:
| public function sortByPosition(array $set, $positionPropertyPath = 'position'): array | |
| public function sortByKey(array $set, $positionPropertyPath = 'position'): array |
There was a problem hiding this comment.
Or rather sortByPropertyPath?
Key would be incorrect.
There was a problem hiding this comment.
yes, also fine with me even though it's not really a property
There was a problem hiding this comment.
| public function sortByPosition(array $set, $positionPropertyPath = 'position'): array | |
| public function sortByPropertyPath(array $set, $positionPropertyPath = 'position'): array |
Previously there was no obvious sorting. With this change the sorting option which is also used for the inspector is used to sort the items and therefore giving an option to the integrator on their arrangement. This changes introduces the sortByPosition method into the Neos.Array Eel helper to make the PositionalArraySorter available in Fusion.
Sebobo
force-pushed
the
bugfix/sort-raw-content-properties
branch
from
0ee0be1
to
f15a8c0
Compare
Previously there was no obvious sorting for properties in the
Raw contentmode and the resulting order of properties appeared "random", which is an issue if the properties don't appear in the order the editor should edit them.With this change the sorting option which is also used for the inspector is used to sort the items and therefore giving an option to the integrator on their arrangement.
That the inspector order is used for the raw content is not the cleanest solution, but introducing another sorting option also doesn't seem the right choice at this point.