TASK: Apply new linter fixes #4953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
changed the title
mhsdesign
requested changes
Mar 18, 2024
There was a problem hiding this comment.
For testing this is totally fine but i just want to block before merge ;)
regarding
We can downmerge those or re-create it in 8.3 and upmerge
i faced a similar problem when i first introduced php stan to flow and agreed with christian to first backport (recreate) on 8.3 then upmerge and then fix the last remaining bits in 9.0. Its surely some work, but i doubt that downmerging nor recreating the change later in 8.3 works cleanly as the history might contain the change twice or other weird things.
|
Closing for now – this is just a distraction currently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip
Related: #4949 #4580