Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix contentgraphintegrity:runviolationdetection #4948

Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Mar 16, 2024

The wiring for flow contentgraphintegrity:runviolationdetection was wrong and needed to be redone.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign marked this pull request as ready for review March 17, 2024 15:40
@kitsunet
Copy link
Member

I would be fine merging this although silently different behavior due to different environments has bitten us a couple of times before, so IDK, maybe there is a way to make this query backwards compatible?

@mhsdesign
Copy link
Member Author

Hmm im not that deep into json functions for maria db. I thought for a second that performance will not matter as this is just run for the behat tests but as i found out there is a cli command that is supposed to be run on large sets of data so better keep it high performing.

... we could add a switch to use php filtering if the json functions are not available but hard to test.

Id say this is just a hack and we can even drop it before final release, when we are sure what we want to support: #4337

Too few arguments to function ContentGraphIntegrityCommandController 0 passed
@mhsdesign mhsdesign force-pushed the task/allowTestsOnOlderMariaDbVersions branch from 8d50b3a to 866c9e4 Compare May 11, 2024 14:04
@mhsdesign mhsdesign dismissed bwaidelich’s stale review May 11, 2024 14:06

Completely refactored ;)

@mhsdesign
Copy link
Member Author

Okay this was rebased and refactored, this change now only contains minimal adjustments to rewire the command as otherwise it will crash (look at the code :D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants