TASK: Disallow disabling tethered nodes

[nezaniel]

Resolves: #4821

[mhsdesign]

❤️

[mhsdesign]

The branch is a bit broken now, i presume as it was dependant on the workspacePr it got rebased or sth?

[mhsdesign]

i tried to cherry pick the changes f3614a755512c22de3c9085afda31db9ef098167 (original commit in details)

Details

From f3614a755512c22de3c9085afda31db9ef098167 Mon Sep 17 00:00:00 2001
From: Bernhard Schmitt <schmitt@sitegeist.de>
Date: Wed, 13 Mar 2024 09:43:13 +0100
Subject: [PATCH] 4821 - Disallow disabling tethered nodes

---
 ...ableNodeAggregate_ConstraintChecks.feature | 22 ++++++++++++++-----
 .../Feature/NodeDisabling/NodeDisabling.php   |  1 +
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/06-NodeDisabling/01-DisableNodeAggregate_ConstraintChecks.feature b/Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/06-NodeDisabling/01-DisableNodeAggregate_ConstraintChecks.feature
index d41691053f..91e3033a1b 100644
--- a/Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/06-NodeDisabling/01-DisableNodeAggregate_ConstraintChecks.feature
+++ b/Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/06-NodeDisabling/01-DisableNodeAggregate_ConstraintChecks.feature
@@ -11,7 +11,11 @@ Feature: Constraint checks on node aggregate disabling
       | language   | de, gsw, en | gsw->de, en     |
     And using the following node types:
     """yaml
-    'Neos.ContentRepository.Testing:Document': []
+    'Neos.ContentRepository.Testing:Tethered': []
+    'Neos.ContentRepository.Testing:Document':
+      childNodes:
+        tethered:
+          type: 'Neos.ContentRepository.Testing:Tethered'
     """
     And using identifier "default", I define a content repository
     And I am in content repository "default"
@@ -30,8 +34,8 @@ Feature: Constraint checks on node aggregate disabling
       | nodeTypeName            | "Neos.ContentRepository:Root" |
     And the graph projection is fully up to date
     And the following CreateNodeAggregateWithNode commands are executed:
-      | nodeAggregateId | nodeTypeName                            | parentNodeAggregateId | nodeName |
-      | sir-david-nodenborough  | Neos.ContentRepository.Testing:Document | lady-eleonode-rootford        | document |
+      | nodeAggregateId | nodeTypeName                            | parentNodeAggregateId | nodeName | tetheredDescendantNodeAggregateIds |
+      | sir-david-nodenborough  | Neos.ContentRepository.Testing:Document | lady-eleonode-rootford        | document | {"tethered": "nodewyn-tetherton"}                   |
 
   Scenario: Try to disable a node aggregate in a non-existing content stream
     When the command DisableNodeAggregate is executed with payload and exceptions are caught:
@@ -58,6 +62,13 @@ Feature: Constraint checks on node aggregate disabling
       | nodeVariantSelectionStrategy | "allVariants"                          |
     Then the last command should have thrown an exception of type "NodeAggregateCurrentlyDoesNotExist"
 
+  Scenario: Try to disable a tethered node aggregate
+    When the command DisableNodeAggregate is executed with payload and exceptions are caught:
+      | Key                          | Value                                  |
+      | nodeAggregateId              | "nodewyn-tetherton"                    |
+      | nodeVariantSelectionStrategy | "allVariants"                          |
+    Then the last command should have thrown an exception of type "NodeAggregateIsTethered"
+
   Scenario: Try to disable an already disabled node aggregate
     Given the command DisableNodeAggregate is executed with payload:
       | Key                          | Value                                  |
@@ -72,14 +83,13 @@ Feature: Constraint checks on node aggregate disabling
       | nodeAggregateId      | "sir-david-nodenborough"               |
       | coveredDimensionSpacePoint   | {"language": "de"}                                     |
       | nodeVariantSelectionStrategy | "allVariants"                          |
-    Then I expect exactly 4 events to be published on stream with prefix "ContentStream:cs-identifier"
-    And event at index 3 is of type "NodeAggregateWasDisabled" with payload:
+    Then I expect exactly 5 events to be published on stream with prefix "ContentStream:cs-identifier"
+    And event at index 4 is of type "NodeAggregateWasDisabled" with payload:
       | Key                          | Expected                               |
       | contentStreamId              | "cs-identifier"                        |
       | nodeAggregateId              | "sir-david-nodenborough"               |
       | affectedDimensionSpacePoints | [{"language":"de"},{"language":"gsw"}] |
 
-
   Scenario: Try to disable a node aggregate in a non-existing dimension space point
     When the command DisableNodeAggregate is executed with payload and exceptions are caught:
       | Key                          | Value                                  |
diff --git a/Neos.ContentRepository.Core/Classes/Feature/NodeDisabling/NodeDisabling.php b/Neos.ContentRepository.Core/Classes/Feature/NodeDisabling/NodeDisabling.php
index 84bcfccd4e..9ae2372b96 100644
--- a/Neos.ContentRepository.Core/Classes/Feature/NodeDisabling/NodeDisabling.php
+++ b/Neos.ContentRepository.Core/Classes/Feature/NodeDisabling/NodeDisabling.php
@@ -60,6 +60,7 @@ private function handleDisableNodeAggregate(
             $nodeAggregate,
             $command->coveredDimensionSpacePoint
         );
+        $this->requireNodeAggregateToBeUntethered($nodeAggregate);
 
         if ($nodeAggregate->disablesDimensionSpacePoint($command->coveredDimensionSpacePoint)) {
             // already disabled, so we can return a no-operation.

but it seems to need further adjustments and conception after the subtree tags

[mhsdesign]

How do we want to continue here?

[nezaniel]

I'd say we allow general tagging but not disabling on tethered nodes for now

[mhsdesign]

Today we discussed we disallow TagSubtree(disable) DisableNodeAggregate for tethered nodes.