BUGFIX: Duplicated content stream in import and export #4914
Conversation
If still imported the importer should log an error.
mhsdesign
force-pushed
the
bugfix/4298-dublicated-contentstream-in-import-and-export
branch
from
f635049
to
918f131
Compare
| @@ -16,7 +18,7 @@ | |||
| /** | |||
| * Processor that exports all events of the live workspace to an "events.jsonl" file | |||
| */ | |||
| final class EventExportProcessor implements ProcessorInterface | |||
| final class EventExportProcessor implements ProcessorInterface, ContentRepositoryServiceInterface | |||
There was a problem hiding this comment.
i made them a cr service so i can instantiate them without much hassle in the tests. As we just had a major discussion about to refactor a lot of thing either way, i think its fine to do this, as this code will be refactored afterwards ^^
Neos.Neos/Tests/Functional/Fixtures/Resources/bed9a3e45070e97b921877e2bd9c35ba368beca0
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Export/src/Processors/EventStoreImportProcessor.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Export/Tests/Behavior/Features/Import/Import.feature
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Export/src/Processors/EventStoreImportProcessor.php
Outdated
Show resolved
Hide resolved
…-contentstream-in-import-and-export
mhsdesign
force-pushed
the
bugfix/4298-dublicated-contentstream-in-import-and-export
branch
from
82d84cc
to
75e53d0
Compare
| "@test:behat-cli -c Neos.TimeableNodeVisibility/Tests/Behavior/behat.yml.dist" | ||
| "@test:behat-cli -c Neos.ContentRepository.Export/Tests/Behavior/behat.yml.dist", | ||
| "@test:behat-cli -c Neos.TimeableNodeVisibility/Tests/Behavior/behat.yml.dist", | ||
| "../../flow doctrine:migrate --quiet; ../../flow cr:setup", |
There was a problem hiding this comment.
Thanks for keeping things tidy. Its different than you think ;)
I just moved the "../../flow doctrine:migrate --quiet; ../../flow cr:setup part two lines below as its only seemingly required for the Neos.Neos tests and not the rest.
We should definitely get rid of this hack and its only needed in the ci but idk why;)
There was a problem hiding this comment.
yeah and believe me im also confused about the fact its in the default development context ... seems to fix a glitch will take care of this at one point ;)
There was a problem hiding this comment.
you're right, this wasn't introduced with your PR but much earlier
But..
./flow cr:setup
in development context has nothing to do with the behat context – or only by accident.
Are you sure that this fixes a glitch, or did we just drag this along?
There was a problem hiding this comment.
@mhsdesign lets see what the CI says: #5005
| "@test:behat-cli -vvv --stop-on-failure -c Neos.TimeableNodeVisibility/Tests/Behavior/behat.yml.dist" | ||
| "@test:behat-cli -vvv --stop-on-failure -c Neos.ContentRepository.Export/Tests/Behavior/behat.yml.dist", | ||
| "@test:behat-cli -vvv --stop-on-failure -c Neos.TimeableNodeVisibility/Tests/Behavior/behat.yml.dist", | ||
| "../../flow doctrine:migrate --quiet; ../../flow cr:setup", |
mhsdesign
deleted the
bugfix/4298-dublicated-contentstream-in-import-and-export
branch
Resolves: #4298
Replaces: #4674
Neos.Demo adjustments: neos/Neos.Demo#191
Neos.Ui adjustments (for the e2e test exports): neos/neos-ui#3729
The
ContentStreamWasCreatedwill NOT be part of the export, as we only export one stream, and only live per jsonl file.(In a later step we might also remove the
contentstreamfield of the event payload, as this might not be used at all)Additionally the importer will ignore any
ContentStreamWasCreatedevents and raise a warning.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions