!!! FEATURE: Overhaul node uri building #4892
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
feature/overhaulNodeUriBuilding
branch
from
a5e9319
to
a90fddb
Compare
mhsdesign
force-pushed
the
feature/overhaulNodeUriBuilding
branch
3 times, most recently
from
ad7df6c
to
f3f34f9
Compare
The new api of the linkhelper was not usable from fusion. The controller context is not available there.
mhsdesign
force-pushed
the
feature/overhaulNodeUriBuilding
branch
from
f3f34f9
to
d32a2d4
Compare
mhsdesign
commented
Mar 20, 2024
Comment on lines
170
to
+171
| $this->runtime->addCacheTag( | ||
| CacheTag::forDynamicNodeAggregate($contentRepository->id, $nodeAddress->contentStreamId, NodeAggregateId::fromString($matches[2]))->value | ||
| CacheTag::forDynamicNodeAggregate($nodeIdentity->contentRepositoryId, $nodeIdentity->workspaceName, $nodeIdentity->nodeAggregateId)->value |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in 9.0-dev the
NodeUriBuilderis a not well though out abstraction. It has a really shallow implementation and doest abstract the uribuilder away, but rather exposes it to be set from outside. That makes it impossible to swap out the implementation and also the api is questionable. How do i really set theformatoption or add additional queryparameters?By creating a clear interface we are completely able to replace the
LinkingServiceand make the linking service eventually use theNodeUriBuildertoo: #4552With the overhaul of the api and introduction of the
NodeUriSpecificationwe will go one step further and not use theNodeAdressany further. TheNodeIdentity#4868 will fill its place and make thus also cross site linking possible: #4441TODO
is it okay to ignore the node uri? neos/flow-development-collection#2157
Related flow pr: neos/flow-development-collection#2744
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions