WIP: Restore LinkingService #4886
Draft
+153
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
changed the title
Converts legacy paths like "/absolute/path", "~/site-relative/path" and "~" to the corresponding AbsoluteNodePath depending on the passed base node. The following syntax is not implemented and handled here: - node:// - /<Neos.Neos:Sites>/my-site/main - some/relative/path Also while legacy and previously allowed, node path traversal like ./neos/info or ../foo/../../bar is not handled.
mhsdesign
force-pushed
the
bugfix/restoreLinkingService
branch
from
54ebe9f
to
0b311df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…createNodeUri
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions