Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Prevent moving nodes to siblings with restrictive ancestors #4693

Closed
wants to merge 3 commits into from
Closed

BUGFIX: Prevent moving nodes to siblings with restrictive ancestors #4693

wants to merge 3 commits into from

Conversation

nezaniel
Copy link
Member

@nezaniel nezaniel commented Nov 2, 2023

Previously, the ancestor constraints were only checked if the new parent id was explicitly given.

Now, they are also checked when only a sibling is defined.

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the 9.0 branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

kitsunet
kitsunet approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, looks good to me.

@bwaidelich bwaidelich removed their request for review January 17, 2024 14:50
bwaidelich
bwaidelich approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate that we extend the read model interface again for a write-side concern, but that's not a new issue.

This PR has conflicts though

@nezaniel
Copy link
Member Author

this becomes obsolete with #4993 anyway

@nezaniel nezaniel closed this Apr 26, 2024
@nezaniel nezaniel deleted the additionalNodeMoveTests branch April 26, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

@kitsunet kitsunet kitsunet approved these changes

@skurfuerst skurfuerst Awaiting requested review from skurfuerst

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nezaniel @bwaidelich @kitsunet