Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 BUG: Make Neos.Neos independent of Neos.Ui #4951

Open
mhsdesign opened this issue Mar 17, 2024 · 1 comment
Open

9.0 BUG: Make Neos.Neos independent of Neos.Ui #4951

mhsdesign opened this issue Mar 17, 2024 · 1 comment
Labels

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Mar 17, 2024

We should not install the Neos Ui in ci runs as this leads to strong coupling between Neos.Neos and the Ui which already happened:

phpstan reports:

Error: Property Neos\Neos\Controller\Service\NodesController::$nodePropertyConverterService has unknown class Neos\Neos\Ui\Domain\Service\NodePropertyConverterService as its type.
Error: Call to method getPropertiesArray() on an unknown class Neos\Neos\Ui\Domain\Service\NodePropertyConverterService.
Error: Property Neos\Neos\Service\ContentElementWrappingService::$userLocaleService has unknown class Neos\Neos\Ui\Domain\Service\UserLocaleService as its type.
Error: Property Neos\Neos\Service\ContentElementWrappingService::$nodeInfoHelper has unknown class Neos\Neos\Ui\Fusion\Helper\NodeInfoHelper as its type.
Error: Call to method switchToUILocale() on an unknown class Neos\Neos\Ui\Domain\Service\UserLocaleService.
Error: Call to method renderNodeWithPropertiesAndChildrenInformation() on an unknown class Neos\Neos\Ui\Fusion\Helper\NodeInfoHelper.
Error: Call to method switchToUILocale() on an unknown class Neos\Neos\Ui\Domain\Service\UserLocaleService.

And Neos will not even boot without the Ui installed:

The object "Neos\Neos\Ui\Domain\Service\NodePropertyConverterService" which was specified as a property in the object configuration of object "Neos\Neos\Controller\Service\NodesController" (automatically registered class) does not exist.

As we use the development distribution which includes the ui we could either remove it or use a custom test distribution

composer remove --no-update neos/neos-ui neos/neos-ui-compiled

having the ui installed leads to 🐔 🥚 problems, for example when the api changes.

@mhsdesign mhsdesign changed the title Dont install Neos Ui in ci runs BUG: Make Neos.Neos independent of Neos.Ui Mar 17, 2024
@mhsdesign
Copy link
Member Author

Also the unit tests are executed of the Neos Ui as well due the config in Build/BuildEssentials/PhpUnit/UnitTests.xml to run every test.

@mhsdesign mhsdesign changed the title BUG: Make Neos.Neos independent of Neos.Ui 9.0 BUG: Make Neos.Neos independent of Neos.Ui May 3, 2024
@mhsdesign mhsdesign added the 9.1 label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant