Neos 9 Support #133
Neos 9 Support #133
Conversation
…collection. fix usage of nodeType.name.
There was a problem hiding this comment.
Wow, impressive, thanks for biting through this!
I'll block this for now, since 9.0 is not available yet and because the work around for the missing signals is not implemented yet – I'm currently working on a simpler hooking mechanism with neos/neos-development-collection#4992 – with that in place, we can probably easily re-implement the "unique form element identifier" mechanism.
I also added some more inline comments
| /.idea/workspace.xml | ||
| /.idea/tasks.xml | ||
| /.idea/markdown-navigator* | ||
| /.idea/shelf | ||
| /dev/.vagrant/ | ||
| /dev/php_errors.log | ||
| /dev/dev-control/ | ||
| /dev/db_backup_* | ||
| /dev/local.itermocil.yaml | ||
|
|
||
|
|
||
| # General swap/backup files | ||
| *.so | ||
| *.log | ||
| *.out | ||
| *~ | ||
| *.swp | ||
| *.DS_Store | ||
| *.sass-cache* | ||
|
|
||
| !*.gitkeep |
There was a problem hiding this comment.
Please ignore these in your local working copy (vi .git/info/exclude)
| { | ||
| return $this->fusionValue('collection'); | ||
| return $this->fusionValue('items'); |
There was a problem hiding this comment.
Just wondering: Why did you rename that? Doesn't that lead to a needless breaking change?
| @@ -4,7 +4,7 @@ | |||
| "description": "Flow Form Framework integration into Neos CMS", | |||
| "license": "GPL-3.0+", | |||
| "require": { | |||
| "neos/neos": "^5.0 || ^7.0 || ^8.0", | |||
| "neos/neos": "^5.0 || ^7.0 || ^8.0 || ^9.0", | |||
There was a problem hiding this comment.
This version will only be compatible with 9.x
| "neos/neos": "^5.0 || ^7.0 || ^8.0 || ^9.0", | |
| "neos/neos": "^9.0", |
Adding Neos 9 compatibilty.
Classes/Package.php, because there are noNodesignal slots anymore. How would we go about that in the future? Do we need to use an Anspect now?