TASK: Use psr buffer stream for string streams #3333
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BufferStream` is simpler as it operates just on a simple string
``` Cannot seek a BufferStream GuzzleHttp\Psr7\BufferStream::seek(0) GuzzleHttp\Psr7\BufferStream::rewind() Neos\Flow\Mvc\ActionResponse::getContent() Neos\FluidAdaptor\Core\Widget\AbstractWidgetViewHelper::initiateSubRequest( ```
mhsdesign
force-pushed
the
task/usePsrBufferStreamForStringStreams
branch
from
d640fc6
to
a7ff07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea is that this is more light weight instead of creating a memory resource.
see https://neos-project.slack.com/archives/C050KKBEB/p1710320388608069
Originally meant as part of #3286, but we dont support buffer streams yet fully in all places.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions