Experiment: FEATURE: Introduce SpecialResponsesSupport
#3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
added a commit
to kitsunet/flow-development-collection
that referenced
this pull request
Feb 3, 2024
Will be split up into an own pr neos#3298
mhsdesign
force-pushed
the
temporary-mvc-refactoring-target-branch
branch
from
57170ee
to
f5b137f
Compare
This reverts commit c96fd84.
…essing any state While looking where the `$this->request` and `$this->response` variables are used i found that they leak also into other objects. So a lot of things are stateful: - $this->request - $this->response - $this->controllerContext - $this->uriBuilder - $this->arguments with that many properties, its just a question of time until one of our utility traits like `SpecialResponsesSupport` accesses - accidentally e.g. in a bugfix - any of them and were doomed. We should take reinforcements like making the trait's methods static
mhsdesign
force-pushed
the
feature/SpecialResponsesSupportHelperForController
branch
from
695ce85
to
2cd48d6
Compare
mhsdesign
changed the title
SpecialResponsesSupport static to avoid accidentally accessing any stateSpecialResponsesSupport
mhsdesign
changed the title
SpecialResponsesSupportSpecialResponsesSupport
mhsdesign
force-pushed
the
temporary-mvc-refactoring-target-branch
branch
2 times, most recently
from
080c854
to
f37ce2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip introduction of the
SpecialResponsesSupportwrite tests ,...
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions