TASK: Remove Neos.Media functionality in resource:clean
#3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reading the code, looking for improvement, it seems tedious that we `getIdentifierByObject` just to `findByIdentifier` a few lines later. This happened due to a funny history of back and forth. At first - 2014 - `resource:clean` was introduced looping over the PersistentResource - neos@8a1ce0f Then - 2016 - it was decided to save the sha1 and loop over them and retrieve the asset via `findOneBySha1` But that did not improve the situation as described in neos#1678 and was removed again - 2019. So in functionality we made a full round, im just here to followup on the last fix to restore the full state syntactically as it was once though of.
Resolves neos#3272 There will be another PR towards Neos.Media to include this functionality in `./flow media:cleanresources`. Additionally warn if this command is used in a Neos installation, and let the dev know that it's preferred to use Neos' command.
mhsdesign
changed the title
resource:clean
mhsdesign
force-pushed
the
task/3272-cleanupNeosMediaDependencyInResourceCleanCommand
branch
from
51acfea
to
53dc4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3275
Resolves #3272
There will be another PR towards Neos.Media to include this functionality in
./flow media:cleanresources.Additionally warn if this command is used in a Neos installation, and let the dev know that it's preferred to use Neos' command.