FEATURE: Files::isAbsolutePath and Files::isRealPath
#3235
Conversation
mhsdesign
changed the title
Files::isAbsolute and Files::isRealPathFiles::isAbsolutePath and Files::isRealPath
Neos.Utility.Files/Classes/Files.php
Outdated
| * That means its absolute and has no directory traversal. | ||
| * {@see realpath()} | ||
| */ | ||
| public static function isRealPath(string $path): bool |
There was a problem hiding this comment.
This could be misleading as the linux realpath has another important function, which is to resolve symlinks, and we do not know if this path contains symlinks. As in /var/www/app/current/Web vs /var/www/app/20231219/Web
There was a problem hiding this comment.
yes maybe isAbsoluteUnixStyleFilePathWithoutDirectoryTraversal ?
This might still be useful just to be able to do a simple optional assertion, so we notice more quickly if something is wrong.
There was a problem hiding this comment.
or isSimpleAbsoluteUnixPath isPureUnixPath or isCleanUnixPath? idk
-> isFullyQualified
There was a problem hiding this comment.
Yes and the symlinking thing is exactly what lead to this bug rendering the helper obsolete.
So I guess we only need the first helper
These new utility methods are needed by neos. And its best to place them into the utility with additional tests.
See
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions