Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Add level option to configuration:show #3224

Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Open

FEATURE: Add level option to configuration:show #3224

wants to merge 1 commit into from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Nov 9, 2023 •
edited

This introduces similar to neos/neos-development-collection#4619 a --level option to flow configuration:show. It helps when inspecting large nested configuration parts and for scouting out only the first few keys:

➜  Framework git:(feature/addLevelOptionToConfigurationShow) ✗ flow configuration:show --path Neos.Neos.userInterface.inspector --level 2
Configuration "Settings: Neos.Neos.userInterface.inspector":

dataTypes:
    string: ...
    integer: ...
    boolean: ...
    array: ...
    Neos\Media\Domain\Model\ImageInterface: ...
    Neos\Media\Domain\Model\Asset: ...
    array<Neos\Media\Domain\Model\Asset>: ...
    DateTime: ...
    reference: ...
    references: ...
editors:
    Neos.Neos/Inspector/Editors/CodeEditor: ...
    Neos.Neos/Inspector/Editors/DateTimeEditor: ...
    Neos.Neos/Inspector/Editors/AssetEditor: ...
    Neos.Neos/Inspector/Editors/ImageEditor: ...
    Neos.Neos/Inspector/Editors/LinkEditor: ...
    Neos.Neos/Inspector/Editors/ReferencesEditor: ...
    Neos.Neos/Inspector/Editors/ReferenceEditor: ...
    Neos.Neos/Inspector/Editors/SelectBoxEditor: ...

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

kitsunet
kitsunet reviewed Nov 10, 2023
View reviewed changes
Neos.Flow/Classes/Command/ConfigurationCommandController.php
* @return void
*/
public function showCommand(string $type = 'Settings', string $path = null)
public function showCommand(string $type = 'Settings', string $path = null, int $level = 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Level suggests to me that it somehow starts at that level? Maybe truncateAfter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm true, i did it similar to neos/neos-development-collection#4619 to be consistent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so id keep at is okay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is the level of how much will be shown and where its truncated.

@kitsunet
Copy link
Member

Ah I see, forgot about the 8.3 because it is still a feature in my mind and shouldn't be in 8.3 ;) well then

@mhsdesign
Copy link
Member Author

But no youre right. I was a bit forcing the level option to go as bugfix into Neos 8.3 neos/neos-development-collection#4619 i assume few people only use it since i introduced the whole nodetypes:show thing only with 8.3.

so im absolutely open for better suggestions and happy to rename the option in neos 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

Assignees
No one assigned
Labels
9.0 Feature
Projects
Neos 9.0
Status: Under Review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mhsdesign @kitsunet