Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Proxy constructors with nullable copied signature #3214

Draft
wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Draft

WIP: Proxy constructors with nullable copied signature #3214

wants to merge 1 commit into from

Conversation

kitsunet
Copy link
Member

@kitsunet kitsunet commented Nov 2, 2023 •
edited

MOVE ALONG NOTHING TO SEE HERE.

Just a quick starting point for having constructors in proxies with compatible and reflectable signature.

This technically creates the constructor as it exists in the original class. We would need to

  • remove property declaration prefixes
  • make all parameters nullable with default null to enable autowiring
  • clean up the code generated in the proxy constructor
  • write tests for edge cases

HOPEFULLY IN THE FUTURE
Fixes: #3076

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked wit !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Nov 2, 2023
@mhsdesign mhsdesign changed the title WIP WIP: Proxy constructors with nullable copied signature Nov 4, 2023
@kitsunet @robertlemke
WIP
107299e 
This technically creates the constructor as it exists in the original
class. We would need to

- remove property declaration prefixes
- make all parameters nullable with default null to enable autowiring
- clean up the code generated in the proxy constructor
- write tests for edge cases
@robertlemke robertlemke force-pushed the task/proxy-constructor-with-compatible-signatures branch from ea210ed to 107299e Compare March 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: named arguments with proxied constructor wont work (fx when passing objects as argument)
1 participant
@kitsunet