Bugfix: Footer Monocle (linkGroups) #570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dmitrijkiltau
commented
Feb 22, 2024
dmitrijkiltau
commented
- Feature: Allow attributes as parameter in Icon component
- Bugfix: Footer Monocle (linkGroups)
- Misc: formatted code
jonnitto
reviewed
Feb 22, 2024
|
|
||
| renderer = Neos.Fusion:Augmenter { | ||
| data-icon-name = ${props.name} | ||
| data-icon-name.@if.hasName = ${props.name} | ||
|
|
||
| class = ${props.class} | ||
| attributes = ${props.attributes} |
There was a problem hiding this comment.
I think this don't work, as it is not a Neos.Fusion:Tag. Shouldn't we use @apply here?
There was a problem hiding this comment.
I used it here and it's working: https://github.com/neos/Neos.NeosIo/pull/570/files#diff-848690a40a1ace0905c7261f04fa62147836e1377c165d75523a454d4322808fR131
I like to add attributes to components, as it get's rid of Neos.Fusion:Augmenter is many cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.