Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Map Teaser #550

Open
wants to merge 4 commits into
base: rebrand
Choose a base branch
from
Open

FEATURE: Map Teaser #550

wants to merge 4 commits into from

Conversation

sbruggmann
Copy link

Teaser with image background variant and optional free content, Tag and TagGroup for Map Teaser

manuelmeister
manuelmeister requested changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@manuelmeister manuelmeister left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
I think the Tag needs to move to an own folder. I'm not sure if the Teaser should have a variant or if its behavior is defined by the presence of the background image.

...ibutionPackages/Neos.Presentation/Resources/Private/Fusion/Atom/Interactive/Interactive.pcss Outdated Show resolved Hide resolved
DistributionPackages/Neos.Presentation/Resources/Private/Fusion/Atom/Interactive/Tag.fusion Outdated Show resolved Hide resolved
@sbruggmann
Copy link
Author

I'd prefer to have an explicit variant.
Maybe in future we need two separate imagesSources to handle differtent requirements, but the still i'd wish to have a variant props to make the state clear.

@nmuens nmuens mentioned this pull request Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelmeister manuelmeister manuelmeister requested changes

Assignees
No one assigned
Labels
Rebrand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbruggmann @manuelmeister @jonnitto