TASK: Adjust to rewrite of _hiddenInIndex to hiddenInMenu
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Apr 20, 2024
| @@ -6,7 +6,7 @@ prototype(Neos.Demo:Content.Registration) < prototype(Neos.Neos:ContentComponent | |||
| renderer = Neos.Fusion.Form:Runtime.RuntimeForm { | |||
| namespace = "neos-demo-registration" | |||
| attributes { | |||
| id = ${'form-' + node.identifier} | |||
| id = ${'form-' + node.property('_identifier')} | |||
There was a problem hiding this comment.
as far as i know this behaviour is deprecated and node.nodeAggregateId.value should be used? Or we could have another flowquery operation for this? q(node).identifier()
There was a problem hiding this comment.
we decided to go for q(node).id() IIRC
mhsdesign
reviewed
Apr 20, 2024
| @@ -13,6 +13,7 @@ prototype(Neos.Demo:Integration.Footer.Renderer) < prototype(Neos.Demo:Presentat | |||
| menuItems = Neos.Fusion:Map { | |||
| items = ${q(site).property('metaNavigationItems')} | |||
| itemRenderer = Neos.Fusion:DataStructure { | |||
| depth = ${node.property('_depth')} | |||
There was a problem hiding this comment.
_depth is also deprecated and should better not be used in the field.
Still deprecated but better is \Neos\Neos\Fusion\Helper\NodeHelper::depth
There was a problem hiding this comment.
why is the depth needed here at all?
There was a problem hiding this comment.
It isn't, I think it was in the past? IDK, removing
mhsdesign
changed the title
_hiddenInIndex to hiddenInMenu
|
yep this is all old and needs to be redone now :) I take care |
Related: #neos-development-collection/4208
…-internal-properties
kitsunet
force-pushed
the
task/adjust-to-removal-internal-properties
branch
from
6c641ee
to
b5bcb57
Compare
mhsdesign
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: neos/neos-development-collection#4921