Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorbet linter #2514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sorbet linter #2514

wants to merge 1 commit into from

Conversation

taq
Copy link
Contributor

@taq taq commented Nov 25, 2020

This is the Sorbet linter. To make sure it will not conflict with the Rubocop linter result, is a good idea install rubocop-sorbet.

@blueyed blueyed added the maker label Dec 17, 2020
@blueyed
Copy link
Member

blueyed commented Dec 17, 2020

To make sure it will not conflict with the Rubocop linter result, is a good idea install rubocop-sorbet.

Should it maybe then not get used by default (if installed)?

Also it would be nice to have some tests with example output - please consider at least providing it here, I can look at adding the test then.

@taq
Copy link
Contributor Author

taq commented Dec 17, 2020

Hey. Yes, being optional is a good idea. Ruby 3 will allow to use type checking, but not everybody will use that.
What output you need? Some sample files with the Sorbet output as text?

@blueyed
Copy link
Member

blueyed commented Dec 19, 2020

What output you need? Some sample files with the Sorbet output as text?

The raw ouput from some test/lint run would be enough - it does not need the input files, but would be mocked.
This is mainly to test the errorformat parsing/handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants