Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to add a maker for an alternate sql linter named sqlfluff.
I'm new to vim's
errorformat
and got a partially working&efm
for sqlfluff's default output format.@blueyed seems really responsive and helpful in PRs, so I am hoping to get some feedback and get this PR working and tested!
Questions:
--dialect
argument. Is there an example maker I could reference for providing a config option for this?&efm
is attempting to match the human output format as I wanted to avoid multi-line errorformats, and json doesn't have line breaks. But after getting message-continuations working, I suspect yaml would be easier than the human format. Suggestions? I can provide example output.PRS
andL003
the efm of%t%n
breaks when the error code isPRS
. How should I handle this case?Here is an example snippet of the human format output: