Add basic support for glslc #2496
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
reviewed
Jul 15, 2020
|
|
||
| function! neomake#makers#ft#glsl#EnabledMakers() abort | ||
| return executable('glslc') ? ['glslc'] : [] | ||
| endfunction |
There was a problem hiding this comment.
executable gets check automatically, so it could/should just return the default makers, i.e. ['glslc'].
| \ '%f: %tarning: %m,' . | ||
| \ '%-G%s', | ||
| \ } | ||
| endfunction |
There was a problem hiding this comment.
Do you have some example output, which could be added as a test then?
For examples search for NeomakeTestsGetMakerWithOutput in tests, e.g. https://github.com/blueyed/neomake/blob/8b7816744ed53f32f460a50dc5431f5d13d081c7/tests/ft_python.vader#L118-L129.
Happy to help if you do not want to do it yourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I've been recently learning Vulkan and I added basic support for ft/glsl using glslc. I'm not sure about portability (using /dev/null because glslc doesn't have a syntax check only -flag), but the maker seems to run ok on my machine. I also considered using glslangValidator instead but couldn't get any errorformat working for it.